Skip to content

fix: update mimir pv config and docs#156

Merged
amdove merged 2 commits intomainfrom
mimir-pv-fix
Mar 3, 2026
Merged

fix: update mimir pv config and docs#156
amdove merged 2 commits intomainfrom
mimir-pv-fix

Conversation

@amdove
Copy link
Collaborator

@amdove amdove commented Feb 27, 2026

Description

  • Add PVC retention policy to Mimir StatefulSets for automatic cleanup on scale-down
  • Rename MIN_AZ_COUNT to MAX_AZ_COUNT in aws_vpc.py (was used as max, not min)
  • Document vpc_az_count setting and when to use 2 AZs to avoid EBS zone affinity issues with StatefulSets

Category of change

  • Bug fix (non-breaking change which fixes an issue)
  • Version upgrade (upgrading the version of a service or product)
  • New feature (non-breaking change which adds functionality)
  • Build: a code change that affects the build system or external dependencies
  • Performance: a code change that improves performance
  • Refactor: a code change that neither fixes a bug nor adds a feature
  • Documentation: documentation changes
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@amdove amdove marked this pull request as ready for review February 27, 2026 21:40
@amdove amdove requested a review from a team as a code owner February 27, 2026 21:40
Copy link
Collaborator

@stevenolen stevenolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@amdove amdove added this pull request to the merge queue Mar 3, 2026
Merged via the queue into main with commit d503f5f Mar 3, 2026
3 checks passed
@amdove amdove deleted the mimir-pv-fix branch March 3, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants